Set and get blocks tip without filtering #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeegomo
reviewed
Jan 2, 2024
consensus-engine/src/lib.rs
Outdated
| @@ -99,6 +97,7 @@ impl<O: Overlay> Carnot<O> { | |||
| let mut new_state = self.clone(); | |||
| if new_state.block_is_safe(block.clone()) { | |||
| new_state.safe_blocks.insert(block.id, block.clone()); | |||
| new_state.tip = block.clone(); | |||
There was a problem hiding this comment.
if block.view > new_state.tip.view ...
bacv
force-pushed
the
consensus-graceful-errors
branch
from
44353c0
to
0c16e70
Compare
zeegomo
approved these changes
Jan 2, 2024
Comment on lines
+35
to
+36
| safe_blocks: [(genesis_block.id, genesis_block.clone())].into(), | ||
| tip: genesis_block, |
There was a problem hiding this comment.
Nitpick: The tip could be just the safe_blocks index.
There was a problem hiding this comment.
That would actually be much nicer. I'll focus now on a testnet instance, do you mind taking this over?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store the tip in a variable and return it when asked.