Receive blocks blobs in parallel #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielSanchezQ
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows demo app to receive blobs of multiple blocks in parallel, thus making demo app instantaneous (compared to previous version) even on a very fast nomos network.
I encourage you to test it on
testnet.nomos.tech.To connect, compile the project and run
./target/debug/nomos-cli chat --network-config nomos-cli/config.yaml --node http://testnet.nomos.tech:18080Note: Be sure to change
nomos-cli/config.yamlnode_keyto something different in case multiple clients connect to the networkNote: Try sending unique messages (e.g. don't send "hi"), there are some limitations in DA at the moment.
Note: Long messages gets disseminated, but for some reason won't show up in the chat.