Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add testnet cli_config and volume #574

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Add testnet cli_config and volume #574

merged 3 commits into from
Jan 30, 2024

Conversation

bacv
Copy link
Member

@bacv bacv commented Jan 29, 2024 •
edited

Three fixes were requried after the grafana and nomos bot addition:

  • Grafana failed to start because of configuration file mode (644), setting it explicitly should help;
  • Nomos chat bot cli params were incorrect, and the configuration filename misspelled;
  • Nomos chat requires openssl libs, and because "build" image was using different debian version, the "exec" image had dependencies in different place with different versions.

@bacv bacv added the testnet label Jan 29, 2024
@bacv bacv added this to the Nomos testnet (playground) milestone Jan 29, 2024
@bacv bacv self-assigned this Jan 29, 2024
@bacv bacv marked this pull request as draft January 29, 2024 15:00
@bacv bacv force-pushed the fix/docker-compose-non-interactive-bot branch from d789a57 to 88e3fe3 Compare January 30, 2024 07:47
@bacv bacv requested a review from jakubgs January 30, 2024 07:47
@bacv bacv marked this pull request as ready for review January 30, 2024 07:52
jakubgs
jakubgs approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@jakubgs jakubgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't add me to reviews for this stuff.

@bacv
Copy link
Member Author

bacv commented Jan 30, 2024

Please don't add me to reviews for this stuff.

Added because you've reported, will skip next time.

@bacv bacv merged commit 3f29058 into master Jan 30, 2024
7 checks passed
@bacv bacv deleted the fix/docker-compose-non-interactive-bot branch January 30, 2024 08:04
al8n pushed a commit that referenced this pull request Mar 4, 2024
@bacv @al8n
Add testnet cli_config and volume (#574)
dff16c9 
* Add cli_config and volume

* Grafana config file mode required on linux hosts

* Pin minideb version for openssl compatibility with the build image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubgs jakubgs jakubgs approved these changes

@yakimant yakimant Awaiting requested review from yakimant

@youngjoon-lee youngjoon-lee Awaiting requested review from youngjoon-lee

Assignees

@bacv bacv

Labels
testnet
Projects
None yet
Milestone
Nomos testnet (playground)
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bacv @jakubgs