Add DA api for explorer and remove unused API #576
Conversation
nodes/explorer/src/main.rs
Outdated
| use nomos_storage::backends::sled::SledBackendSettings; | ||
| use nomos_storage::{backends::sled::SledBackend, StorageService}; | ||
|
|
||
| #[derive(Services)] | ||
| struct Explorer { | ||
| log: ServiceHandle<Logger>, | ||
| storage: ServiceHandle<StorageService<SledBackend<Wire>>>, | ||
| da: ServiceHandle<DataAvailability>, |
There was a problem hiding this comment.
Why is there a da service here?
There was a problem hiding this comment.
Because in da_blobs fn, we need to connect to the DataAvailability service.
...
let relay = handle.relay::<DataAvailability>().connect().await?;
...There was a problem hiding this comment.
This do not work as you think. The node explorer should not have this service.
There was a problem hiding this comment.
Ah, thanks, you are right. In this case, we should fetch the DA blobs from persistent storage. Currently, all of the DA blobs seem to be in the memory pool.
There was a problem hiding this comment.
We need to think about that indeed. Blobs can be retrieve from the node directly for now. But at some point we should derivate into something like storage.
There was a problem hiding this comment.
The blobs at the moment are stored in BlobCache which implements DaBackend. It has get/add/remove functions. It seems that this was created with an idea to be replaced with other storage. Maybe we could add a sled DaBackend there?
There was a problem hiding this comment.
Maybe we could add a sled DaBackend there?
Yeah, I think so. This is the only way to offload blobs query from the consensus layer to the explorer.
There was a problem hiding this comment.
I need to check. But in this case we could have a backend that keeps the memmory cache and the sled one. But definitely not do over this pr.
|
So, right now this is a kind of proxy for the node api call right? I think we should probably wait till we have the storage draft and then consider from there. |
Right now, we can fetch blocks directly from explorer, but cannot query da blobs by explorer. |
yes, so there is no point on having this until we use the storage itself. |
Ok, I will still use the consensus layer to fetch the DA blobs for the demo. What do you think @bacv? |
Yes, i think for this pr lets leave it as is. |
There was a problem hiding this comment.
@al8n This is previous to the rockdb backend. Do not know if we should merge this or the other to see if everything works as expected.
No description provided.