RocksDB Storage service #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| /// Rocks transaction type | ||
| // Do not use `TransactionDB` here, because rocksdb's `TransactionDB` does not support open by read-only mode. | ||
| // Thus, we cannot open the same db in two or more processes. |
There was a problem hiding this comment.
So, we cannot have a process writing and a process reading?
There was a problem hiding this comment.
We can because we use DB here, not the TransactionDB. rocksdb crate has two kinds of db, DB and TransactionDB, TransactionDB does not allow one read process while one write process. However, DB supports.
I added a bin, so we can manually test it by using two processes, and there is also a unit test with one write thread, and multiple threads read. |
danielSanchezQ
approved these changes
Feb 28, 2024
youngjoon-lee
approved these changes
Feb 29, 2024
| async fn test_store_load_remove( | ||
| ) -> Result<(), <RocksBackend<NoStorageSerde> as StorageBackend>::Error> { | ||
| let temp_path = TempDir::new().unwrap(); | ||
| let sled_settings = RocksBackendSettings { |
There was a problem hiding this comment.
Suggested change
| let sled_settings = RocksBackendSettings { | |
| let rocks_settings = RocksBackendSettings { |
also, in other tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement RocksDB storage service, not use
TransactionDBas it does not support open in read-only mode.