Integrate explorer #603
Integrate explorer #603
Conversation
| "-C", | ||
| "link-args=-framework CoreFoundation -framework Security -framework CoreServices -lresolv", | ||
| ] |
There was a problem hiding this comment.
This may be changed by fmt tools, will change it back.
| match self | ||
| .carnot_tree | ||
| .committee_by_member_id(&id) | ||
| .map(|c| apply_threshold(c.len(), self.threshold)) | ||
| .expect("node is not part of any committee") | ||
| { | ||
| Some(threshold) => threshold, | ||
| None => panic!("node {id} is not part of any committee"), | ||
| } |
There was a problem hiding this comment.
Why is there a change in the carnot tree in this PR?
There was a problem hiding this comment.
Ah, this is used when I debugging, forget to change it back.
There was a problem hiding this comment.
This is still here. As well as other few changes and nitpicks.
nomos-cli/src/cmds/chat/mod.rs
Outdated
| pub fn run_app_without_terminal( | ||
| &self, | ||
| username: String, | ||
| ) -> Result<(std::sync::mpsc::Receiver<Vec<ChatMessage>>, App), Box<dyn std::error::Error>> |
There was a problem hiding this comment.
Where is this used?
There was a problem hiding this comment.
This will be used in the chat demo test, I do not upload that test case because of a wired "addr already in used" error.
| ONCE_INIT.call_once(move || { | ||
| registry_init!(layer, config.format, config.level); | ||
| }); |
There was a problem hiding this comment.
What is the issue with the registry?
There was a problem hiding this comment.
Running multiple Overwatch services with log service in one test case in different threads will lead to panic as tracing only allows setting global subscriber once. There is PR #577 for it, I will update that PR to feature gate this in test.
|
There are failing checks. Overall looks ok. |
The test cases in this PR shows that the explorer can work as expectedly.