Add cryptarchia consensus service #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeegomo
force-pushed
the
cryptarchia-consensus
branch
from
8e4c68a
to
3c18ac4
Compare
davidrusu
reviewed
Mar 15, 2024
Comment on lines
49
to
50
| fn try_apply_header(&self, header: &Header) -> Result<Self, Error> { | ||
| let header = header.cryptarchia(); |
There was a problem hiding this comment.
Why not simply take cryptarchia::Header here and force the caller to prove an instance of cryptarchia::Header?
This seems falsely general (i.e. type sig claims to work for any header)
davidrusu
reviewed
Mar 15, 2024
| let ledger = self.ledger.try_update( | ||
| id, | ||
| parent, | ||
| header.slot(), |
There was a problem hiding this comment.
header.slot() is stored in the slot variable above.
Is header moved in this call to try_update()? If not, you could inline all the variables (id()|parent()|slot())
youngjoon-lee
approved these changes
Mar 15, 2024
zeegomo
force-pushed
the
cryptarchia-consensus
branch
from
3421375
to
89e9b09
Compare
zeegomo
force-pushed
the
cryptarchia-consensus
branch
from
89e9b09
to
a4c3f80
Compare
davidrusu
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR for adding cryptarchia support in nomos node.
Leadership and tests will come in following iterations