Replace mixnet backend with mixnet addon #615
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details
I've felt that it's not natural to have the "mixnet network backend" separately from the libp2p network backend. Now I think it's more natural to have only one network backend (libp2p) for now and have mixnet as an addon for the libp2p network backend. There are several reasons:
mixnet
network backend for that, as below?There might be several solutions, but I end up thinking about making the mixnet as an add-on for each network backend, so that we can enable/disable mixnet no matter which network backend we choose. Of course, we're going to make the mixnet mandatory in production, but please be remined that we've discussed to make it opt-in for easy development for the time being.
With this structure, we will have only one network backend (libp2p). If we build the nomos-node with only the libp2p feature, the mixnet is disabled.
If we build it with both libp2p and mixnet feature, the mixnet is enabled for the libp2p network backend.