Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixnet: Add basic structure and topology construction #44

Merged
merged 9 commits into from
Jan 10, 2024

Conversation

@youngjoon-lee youngjoon-lee self-assigned this Jan 9, 2024
@youngjoon-lee youngjoon-lee marked this pull request as ready for review January 9, 2024 06:10
mixnet/fisheryates.py Outdated Show resolved Hide resolved
mixnet/mixnet.py Show resolved Hide resolved
mixnet/mixnet.py Outdated Show resolved Hide resolved

@dataclass
class MixnetTopology:
layers: List[List[MixNode]]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: empty line at the end of file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's because of the difference between python formatters. I use black for formatting and isort for sorting imports. Which formatter do you use? I can make a sync.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could probably standarize ruff as formatter and linter. It's built in rust!!

@youngjoon-lee youngjoon-lee merged commit 2fe4209 into package-prefix Jan 10, 2024
1 check passed
youngjoon-lee added a commit that referenced this pull request Jan 10, 2024
@youngjoon-lee youngjoon-lee deleted the mixnet branch January 15, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants