Mixnet: Sphinx packet builder for mix clients #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, and raise error instead of assertion
danielSanchezQ
approved these changes
Jan 12, 2024
|
@danielSanchezQ I just modified this PR to use the pysphinx that we published to pypi: |
youngjoon-lee
added a commit
that referenced
this pull request
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the 3rd PR of the series of Mixnet specification.
This PR covers https://www.notion.so/Mixnet-Specification-807b624444a54a4b88afa1cc80e100c2?pvs=4#df9f03a808134ae19c085ca40b82161c and its all sub-sections.
In shorts, this PR defines the way how mix clients (Nomos nodes) use the Sphinx library (defined in PR #46) to construct packets for real and cover traffic.
Previously in our v0 Rust implementation, we've used Nym's Sphinx-wrapper implementation: https://github.com/nymtech/nym/tree/v1.1.22/common/nymsphinx, instead of implementing our own. But now, we have more understandings of Sphinx, and I found that their wrapper implementation is very verbose and not easy to modify if we want.
I think it's not very complicated to have our own Sphinx-wrapper as defined in this PR.
Like PR #46, I've tried to use the same term and structure as Nym's just in case, even if some parts are not clean in perspective of engineering.