Spec. Leader Coin Evolution #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeegomo
reviewed
Feb 6, 2024
|
|
||
| h = blake2b(digest_size=32) | ||
| h.update(b"coin-evolve") | ||
| h.update(sk_bytes) |
There was a problem hiding this comment.
curious why we include the secret key here
There was a problem hiding this comment.
From the spec, the PRF is keyed by root_c:
Where root_c is the root of the coin's merkle-tree (aka, the secret key)
|
|
||
| @property | ||
| def pk(self): | ||
| return self.sk |
There was a problem hiding this comment.
Yeah, it's just a mock, not really important right now. Do you want something like hash(sk)?
cryptarchia/messages.abnf
Outdated
| @@ -9,7 +9,7 @@ CONTENT-SIZE = U32 | |||
| BLOCK-DATE = BLOCK-SLOT | |||
| BLOCK-SLOT = U64 | |||
| PARENT-ID = HEADER-ID | |||
| MOCK-LEADER-PROOF = COMMITMENT NULLIFIER | |||
| MOCK-LEADER-PROOF = COMMITMENT NULLIFIER COMMITMENT | |||
There was a problem hiding this comment.
nit: add a comment explaining which commitment is for what
zeegomo
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coin.evolve()which evolves the coins nonceevolved_commitmentwhich are added to the set of eligible commitments.commitments_spendfor commitments that are eligible for spendingcommitments_leadfor commitments that are eligible for leadingcommitments_to_leadledger_state