Da specs #70
Merged
Da specs #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I finished the first review. looks nice 🚀 |
|
I'm merging and open deeper PRs on top of it. |
Comment on lines
+14
to
+22
| assert len(encoded_data.row_commitments) == len(self.nodes) | ||
| assert len(encoded_data.row_proofs) == len(self.nodes) | ||
| columns = encoded_data.extended_matrix.columns() | ||
| column_commitments = encoded_data.column_commitments | ||
| row_commitments = encoded_data.row_commitments | ||
| rows_proofs = encoded_data.row_proofs | ||
| aggregated_column_commitment = encoded_data.aggregated_column_commitment | ||
| aggregated_column_proof = encoded_data.aggregated_column_proof | ||
| for index, (column, column_commitment, row_proofs) in enumerate(zip(columns, column_commitments, rows_proofs)): |
There was a problem hiding this comment.
nitpick: It seems that we also need to assert len(columns) == len(column_commitments) == len(self.nodes) (or == len(row_proofs), so we can make sure that the zip in the line 22 produces the expected number of elements. I came up with this point when reading the disperse function below. But, this is not very important. Also, it's okay if the definition of columns and column_commitments already imply this property.
There was a problem hiding this comment.
Good catch. I'll add this in subsequent PRs. Thanks!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the main branch for nomos da specs. Currently there is a broad skeleton of what we intend to do without any of the kzg+rs implementation. This may be a bit too big already. I intend to at least fill a few more tests here and then use other branches to merge on top of this.
Notice that this is incomplete and open as a draft, but reviews are more than welcome.