KZG core functionality #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielSanchezQ
commented
Feb 26, 2024
| from sympy import ntt, intt | ||
|
|
||
|
|
||
| class Polynomial[T]: |
There was a problem hiding this comment.
This may feel too much, but, the polynomial implementations available (numpy, simpy) are way too much, they use inverse representation and they are difficult to operate with. This implementation is simple enough for our purposes.
danielSanchezQ
force-pushed
the
da-kzg-core
branch
from
689712e
to
81bf054
Compare
|
Maybe adding "verify setup" can be helpful to check the integrity of trusted setup procedure. |
added verify setup mechanism
…up verification test
|
LGTM |
| class TestKZG(TestCase): | ||
|
|
||
| @staticmethod | ||
| def rand_bytes(size=1024): |
There was a problem hiding this comment.
I'm late to review this PR, but have a quick question. It seems like this parameter size should be n_chunks if I understand correctly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the easiest workig version of kzg we could came up with.
Commitment + Proof + Verification
Almost everything implemented from scratch for easier understanding.
No reed solomon involved which will be introduced later on in a different PR