Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Da encoding protocol #76

Merged
merged 23 commits into from
Mar 8, 2024
Merged

Da encoding protocol #76

merged 23 commits into from
Mar 8, 2024

Conversation

danielSanchezQ
Copy link
Collaborator

@danielSanchezQ danielSanchezQ commented Mar 5, 2024

  • Fill up the encoding protocol structure with the actual specification
  • Expand an implement tests

@danielSanchezQ danielSanchezQ changed the title Da protocol Da encoding protocol Mar 7, 2024
@danielSanchezQ danielSanchezQ self-assigned this Mar 7, 2024
@danielSanchezQ danielSanchezQ marked this pull request as ready for review March 7, 2024 15:04
@megonen
Copy link
Contributor

megonen commented Mar 8, 2024

We can use SHA3 (Keccak) for hash. (since it's a newer standard). It is called sha3_256() in hashlib.

@megonen
Copy link
Contributor

megonen commented Mar 8, 2024

I have a new idea. We can publish column commitments, but when calculating the agg_com value, we can calculate the commitment value of H(ColumnComm)_i values. This way, if someone wants to add an extra column, they will not be able to add it because it is over the agg_com hash, and we will provide the things we provided in our previous design.

Copy link
Contributor

@megonen megonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielSanchezQ danielSanchezQ merged commit cf899d2 into master Mar 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants