-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Da encoding protocol #76
Conversation
danielSanchezQ
commented
Mar 5, 2024
•
edited
edited
- Fill up the encoding protocol structure with the actual specification
- Expand an implement tests
Added test for columns
Added row commitments size test
0c08647
to
0fa9f5e
Compare
Added aggregated commitment test Fixed and expanded encode test
We can use SHA3 (Keccak) for hash. (since it's a newer standard). It is called |
I have a new idea. We can publish column commitments, but when calculating the agg_com value, we can calculate the commitment value of H(ColumnComm)_i values. This way, if someone wants to add an extra column, they will not be able to add it because it is over the agg_com hash, and we will provide the things we provided in our previous design. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM