Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Da api ext tests #85

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Da api ext tests #85

merged 3 commits into from
Mar 22, 2024

Conversation

bacv
Copy link
Member

@bacv bacv commented Mar 18, 2024

Couple tests to demonstrate storing of the same blob with different indexes.

@bacv bacv self-assigned this Mar 18, 2024
@danielSanchezQ
Copy link
Collaborator

@davidrusu @megonen @alvatar
We realized that publishing exactly the same data could happen. At the moment the identification for a published blob depend on the data itself, so publishing the same blob twice (or more) would result in the same identification. This opens a few questions:

  • I think is an opportunity for optimization (?) you do not need to store a blob if you already have it, you just add an index to the same data (?)
  • Should we rather consider them independent so they are duplicated? (This would result in adding an specific information to the identifier hash).

@bacv bacv merged commit 10a5cc4 into da-api-tests Mar 22, 2024
1 check passed
@bacv bacv deleted the da-api-ext-tests branch March 22, 2024 10:28
bacv added a commit that referenced this pull request Mar 22, 2024
@bacv
Da api ext tests (#85)
a913400 
* Index store links blob to cert_id

* Tests for multiple indexes pointing to the same blob

* Test multiple indexes to the same blob in the full flow
bacv added a commit that referenced this pull request Mar 22, 2024
@bacv @danielSanchezQ
DA Api Tests (#83)
53b8be7 
* Tests for da api full flow

* Fix test issues

* Da api ext tests (#85)

* Index store links blob to cert_id

* Tests for multiple indexes pointing to the same blob

* Test multiple indexes to the same blob in the full flow

* Update bytes_per_chunk to 31 bytes

---------

Co-authored-by: Daniel Sanchez Quiros <sanchez.quiros.daniel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielSanchezQ danielSanchezQ danielSanchezQ approved these changes

Assignees

@bacv bacv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bacv @danielSanchezQ