refactor: use custom error type instead of error strings #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x-r4bbit
force-pushed
the
feat/deploy-script
branch
from
c7d5800
to
f0c1953
Compare
0x-r4bbit
force-pushed
the
refactor/custom-error
branch
from
2cc0381
to
1fba2f1
Compare
3esmit
approved these changes
Oct 5, 2023
The `onlyBridge` modifier uses strings as error messages which are expensive in gas. This commit refactors this to use a custom error type instead and also introduces some basic tests to ensure the errors are emitted properly. It also adds some sanity tests for minting and burning bridge tokens.
0x-r4bbit
force-pushed
the
refactor/custom-error
branch
from
1fba2f1
to
a1290dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
onlyBridgemodifier uses strings as error messages which are expensive in gas.This commit refactors this to use a custom error type instead and also introduces some basic tests to ensure the errors are emitted properly.
It also adds some sanity tests for minting and burning bridge tokens.
Checklist
Ensure you completed all of the steps below before submitting your pull request:
forge snapshot?pnpm lint?forge test?