feat: introduce VaultFactory
#38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x-r4bbit
force-pushed
the
feat/vault-factory
branch
from
93dbb1c
to
bfeac72
Compare
0x-r4bbit
requested review from
gravityblast and
3esmit
and removed request for
3esmit and
gravityblast
0x-r4bbit
force-pushed
the
feat/vault-factory
branch
from
bfeac72
to
d6244ab
Compare
3esmit
approved these changes
Nov 1, 2023
0x-r4bbit
force-pushed
the
refactor/staked-token
branch
from
296cd0a
to
974f775
Compare
This commit introduces a first version of a `VaultFactory` that later will be extended to be capable of instantiating reward vaults and possible keep track of vault instances per owner. As a first step, this implementation comes with a `createVault()` function which takes care of creating vaults. Because `VaultFactory` also knows about `StakeManager` it can derive the manager's address and stake token from it when creating vaults, allowing the API to be without arguments. Partially addresses #37
0x-r4bbit
force-pushed
the
feat/vault-factory
branch
from
d6244ab
to
8e2b9f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a first version of a
VaultFactorythat later will be extended to be capable of instantiating reward vaults and possible keep track of vault instances per owner.As a first step, this implementation comes with a
createVault()function which takes care of creating vaults.Because
VaultFactoryalso knows aboutStakeManagerit can derive the manager's address and stake token from it when creating vaults, allowing the API to be without arguments.Partially addresses #37
Checklist
Ensure you completed all of the steps below before submitting your pull request:
forge snapshot?pnpm lint?forge test?