chore(StakeManagerProcessAccount.spec): add specs for processAccount #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3esmit
approved these changes
Feb 19, 2024
This primarily adds a rule that ensures that, when an account's `balance` changes, `_processAccount()` must have been called as well. There's very few exceptions where an account's `balance` can change without the need of `_processAccount()` but those functions have been deliberately excluded from the rule.
0x-r4bbit
force-pushed
the
chore/process-account-specs
branch
from
cac3cc7
to
9f3df7b
Compare
0x-r4bbit
commented
Mar 13, 2024
|
|
||
| // If the account's `lockUntil` == 0, then the account will be initialized | ||
| // with the current epoch and no processing is required. | ||
| require getAccountLockUntil(account) > 0; |
There was a problem hiding this comment.
Ha, this was a tricky one to find.
Was debugging a counter example, without realizing that the accountProcessed ghost was never touched.
|
@3esmit re-requesting review on this one. I've finally managed to get this one pass. However, I've changed the base branch of this PR after I've pushed my update, so the CI actions aren't triggered. I've triggered them manually here: https://github.com/logos-co/staking/actions/runs/8264004339 |
|
This has been sitting here for almost a week since a re-review was requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Ensure you completed all of the steps below before submitting your pull request:
forge snapshot?pnpm lint?forge test?pnpm verify?