refactor: migrate repository to foundry-template #6
Conversation
| | ------------ | -------- | -------- | ---------- | | ||
| | | | | | | ||
| | | | | | | ||
| | | | | | |
There was a problem hiding this comment.
With these I think we need to put our heads together and figure out what the invariants are
| } |
There was a problem hiding this comment.
Changes done in this file are just formatting to make the linter happy
| } |
There was a problem hiding this comment.
Same here, just formatting
| function mint(address _destination, uint256 _amount) external onlyOwner { | ||
| _mint(_destination, _amount); | ||
| } | ||
| } |
There was a problem hiding this comment.
I've removed this one and added test/mocks/MockERC20.sol
contracts/legacy/Owned.sol
Outdated
| } |
There was a problem hiding this comment.
Just formatting changes from forge fmt
contracts/legacy/SNTFaucet.sol
Outdated
| } |
There was a problem hiding this comment.
Same here, just formatting changes
contracts/legacy/SNTPlaceHolder.sol
Outdated
| } |
There was a problem hiding this comment.
Formatting changes only
contracts/legacy/SafeMath.sol
Outdated
| return a < b ? a : b; | ||
| } | ||
| } |
There was a problem hiding this comment.
Not sure about the entire legacy folder here, but SafeMath is most likely something we can drop altogether since solidity 0.8
There was a problem hiding this comment.
@3esmit Do you know if we need the legacy folder at all?
It didn't seem to be used even prior to the changes I've made in this PR.
There was a problem hiding this comment.
We should be able to drop it
There was a problem hiding this comment.
Removed the legacy folder
| assertEq(stakeManager.owner(), deployer); | ||
| assertEq(stakeManager.totalSupply(), 0); | ||
| } | ||
| } |
There was a problem hiding this comment.
This essentially replaces StakeManager.js
| constructor() ERC20("Mock SNT", "SNT") { | ||
| _mint(msg.sender, 1_000_000_000_000_000_000); | ||
| } | ||
| } |
There was a problem hiding this comment.
This is the new mock that replaces Token.sol
0x-r4bbit
force-pushed
the
refactor/foundry-template
branch
2 times, most recently
from
5b11dc2
to
d44449e
Compare
This commit migrates the repo to our foundry template, which ensures we have consistent tooling across smart contract repositories that are maintained by Vac. This removes all hardhat related files and workflows and replaces them with more perfomant foundry workflows. It also sets up tests, CI and linting.
0x-r4bbit
force-pushed
the
refactor/foundry-template
branch
from
d44449e
to
d37ebd0
Compare
This commit migrates the repo to our foundry template, which ensures we have consistent tooling across smart contract repositories that are maintained by Vac.
This removes all hardhat related files and workflows and replaces them with more perfomant foundry workflows.
It also sets up tests, CI and linting.