fix(StakeManager): use OpenZeppelin Math to avoid precision loss in int divisions #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3esmit
force-pushed
the
fix-precision-loss
branch
6 times, most recently
from
9ab32a2
to
ad22d67
Compare
|
@0x-r4bbit Do you have any idea why lint is failing?
forge --version |
3esmit
force-pushed
the
fix-precision-loss
branch
from
ad22d67
to
09d07e9
Compare
5 tasks
|
The lint error is caused by this commit d7be979 as shown in vacp2p/foundry-template#18 |
|
I found the error in lint, was a stupid EOF from Windows. I will now redo everything here. |
3esmit
force-pushed
the
fix-precision-loss
branch
from
09d07e9
to
81a28da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Alternative to #67;
This PR fixes #64 and Fixes #24
Checklist
Ensure you completed all of the steps below before submitting your pull request:
forge snapshot?pnpm lint?forge test?pnpm verify?