fix(StakeManager): don't allow migration initialization while migrating #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x-r4bbit
force-pushed
the
fix/certora-compile
branch
2 times, most recently
from
b81e370
to
109b684
Compare
0x-r4bbit
force-pushed
the
fix/certora-specs
branch
from
a4dfc33
to
3e25e7c
Compare
0x-r4bbit
changed the base branch from
fix/certora-compile
to
fix/current-contract
This is actually a bug that the certora prover found. The rule `epochStaysSameOnMigration` failed because a previous `StakeManager` could call `migrationInitialize` and change `currentEpoch` on a next `StakeManager`, even though the next `StakeManager` might be in migration itself (which means the `currentEpoch` is now allowed to change). This commit fixes this by ensure `migrationInitialize()` will revert if the `StakeManager` already has a `migration` on going.
0x-r4bbit
force-pushed
the
fix/current-contract
branch
from
cd7f41d
to
ad224c4
Compare
0x-r4bbit
force-pushed
the
fix/certora-specs
branch
from
3e25e7c
to
235b347
Compare
|
This commit should actually pass just fine. For some reason, CI is taking an outdated state of the rules. |
3esmit
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
Ha! Thats a nice one.
This check ensures that its impossible for the old contract to request a migration to a contract that is already in migration. Will prevent someone on making a deployment mistake or accidentally calling migrateTo with the address of an incorrect state.
There was no checks that require the new contract to behave as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is actually a bug that the certora prover found. The rule
epochStaysSameOnMigrationfailed because a previousStakeManagercould callmigrationInitializeand changecurrentEpochon a nextStakeManager, even though the nextStakeManagermight be in migration itself (which means thecurrentEpochis now allowed to change).This commit fixes this by ensure
migrationInitialize()will revert if theStakeManageralready has amigrationon going.Checklist
Ensure you completed all of the steps below before submitting your pull request:
forge snapshot?pnpm gas-report?pnpm lint?forge test?pnpm verify?