Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatability issues of IPLoM module on Python 3 #22

Merged
merged 2 commits into from Mar 20, 2019
Merged

Compatability issues of IPLoM module on Python 3 #22

merged 2 commits into from Mar 20, 2019

Conversation

JoeHitHard
Copy link
Contributor

No description provided.

@JoeHitHard JoeHitHard changed the title Import error in IPLoM module Error's in IPLoM module Mar 20, 2019
zhujiem
zhujiem reviewed Mar 20, 2019
View reviewed changes
Copy link
Member

@zhujiem zhujiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoeHitHard Could you hightlight the changes in IPLoM.py?

zhujiem
zhujiem reviewed Mar 20, 2019
View reviewed changes
Copy link
Member

@zhujiem zhujiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you use Python 3?

JoeHitHard
JoeHitHard commented Mar 20, 2019
View reviewed changes
logparser/IPLoM/IPLoM.py
for currentRex in self.para.rex:
line = re.sub(currentRex, '', line)

wordSeq = list(filter(lambda x: x != '', re.split(r'[\s=:,]', line)))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the only change

@JoeHitHard
Copy link
Contributor Author

Yes, I used Python3
There are only 2 changes:

  1. In IPLom.init.py Import error
    previous:
from IPLoM import *

changed:

from .IPLoM import *
  1. In IPLom.IPLoM.py
    line number 108:
    previous
wordSeq = filter(lambda x: x != '', re.split(r'[\s=:,]', line))

changed:

wordSeq = list(filter(lambda x: x != '', re.split(r'[\s=:,]', line)))

@zhujiem zhujiem changed the title Error's in IPLoM module Error's in IPLoM module runing on Python 3 Mar 20, 2019
@zhujiem zhujiem changed the title Error's in IPLoM module runing on Python 3 Compatability issues of IPLoM module on Python 3 Mar 20, 2019
@JoeHitHard
Copy link
Contributor Author

Hey, in Spell also there are few Compatability issues in Python 3

@zhujiem zhujiem merged commit f1294a4 into logpai:master Mar 20, 2019
ztz1989 pushed a commit to ztz1989/logparser that referenced this pull request Feb 12, 2022
@JoeHitHard
Compatability issues of IPLoM module on Python 3 (logpai#22)
6eaabd6 
Add compatability of IPLoM on Python 3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhujiem zhujiem zhujiem left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JoeHitHard @zhujiem @JosephMeghanath