log: unify handling of log levels #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgzones
reviewed
May 27, 2022
kdudka
added a commit
to kdudka/logrotate
that referenced
this pull request
May 27, 2022
Use MESS_WARN instead of MESS_NORMAL and make it always use the `warning:` prefix. MESS_WARN is now mapped to LOG_WARNING for syslog. Also drop MESS_VERBOSE, which was not set anywhere. Closes: logrotate#449
cgzones
reviewed
May 27, 2022
kdudka
added a commit
to kdudka/logrotate
that referenced
this pull request
May 27, 2022
Use MESS_WARN instead of MESS_NORMAL and make it always use the `warning:` prefix. MESS_WARN is now mapped to LOG_WARNING for syslog. Also drop MESS_VERBOSE, which was not set anywhere. Closes: logrotate#449
kdudka
added a commit
to kdudka/logrotate
that referenced
this pull request
May 30, 2022
Use MESS_WARN instead of MESS_NORMAL and make it always use the `warning:` prefix. MESS_WARN is now mapped to LOG_WARNING for syslog. Also drop MESS_VERBOSE, which was not set anywhere. Closes: logrotate#449
cgzones
approved these changes
Jun 1, 2022
|
Does this one supersedes #239? |
|
Yes, good point, except that this pull request does not add the |
Use MESS_WARN instead of MESS_NORMAL and make it always use the `warning:` prefix. MESS_WARN is now mapped to LOG_WARNING for syslog. Also drop MESS_VERBOSE, which was not set anywhere. Closes: logrotate#239 Closes: logrotate#449
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
MESS_WARNinstead ofMESS_NORMALand make it always use thewarning:prefix. Also dropMESS_VERBOSE, which was not set anywhere.