Add support for Light colors and Bright modifier #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, didn't run the tests... realize the color change made it fail... I might try to fix that later |
|
You really have setup the tests to prevent me from being lazy... I'll fix the code coverage some other day... :) |
|
And we are back at 100% coverage... so feel free to merge. |
|
Ok, I'm reviewing it. |
|
Wait with the review, I just realize that I use the same BrightFm modifier for both background and foreground, which means you can't mix a dark background and a bright foreground. |
snaggen
changed the title
Also removed the Bright function, it is not really useful on its own.
snaggen
changed the title
|
Now this should be ok for review again. |
|
Ok, thank you, sir. I'm reviewing it. |
logrusorgru
added a commit
that referenced
this pull request
Apr 17, 2019
|
A bit remastered. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for more ansi colors, the light ones.
However, it made things a little strange so I have done some adjustments.
The previous Gray was really Dark White, so now with addition of light colors we also have Light Black which is a darker gray than dark white. So I have changed them for so the dark white is now Light Gray and dark black is gray. So basically, this means that for existing applications using Gray, it just got darker.
Also, there is no LightBrown, since Brown really was dark yellow. So the Light Brown is just called Yellow.