Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on "More" doesn't close search modal #5794

Closed
giuseppedandrea opened this issue Jun 22, 2022 · 0 comments
Closed

Clicking on "More" doesn't close search modal #5794

giuseppedandrea opened this issue Jun 22, 2022 · 0 comments

Comments

@giuseppedandrea
Copy link
Contributor

What happened?

After clicking on "More" in the search modal, results are shown in the "background" page but the modal doesn't close. "More" is shown only when the results are many (I think the limit is 20 blocks).

Reproduce the Bug

  1. Press ctrl-k
  2. Search for a term written in at least 20 blocks
  3. Scroll down and click on "More"
  4. To see the results you need to press esc or click outside the modal

Expected Behavior

After clicking "More", search modal should close and the results shown on the page.

Screenshots

No response

Desktop Platform Information

No response

Mobile Platform Information

No response

Additional Context

:on-click (fn []
(when-not (string/blank? search-q)
(search-handler/search (state/get-current-repo) search-q {:limit 1000
:more? true})
(search-handler/clear-search!)))}

A possible solution could be calling (state/close-modal!) after (search-handler/clear-search!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants