Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context menu stucks when pressing back on Android #9872

Closed
1 of 2 tasks
Adel0n opened this issue Jul 16, 2023 · 2 comments · Fixed by #9882
Closed
1 of 2 tasks

Context menu stucks when pressing back on Android #9872

Adel0n opened this issue Jul 16, 2023 · 2 comments · Fixed by #9882
Assignees
Labels
:type/bug Something isn't working. Affects daily use.

Comments

@Adel0n
Copy link

Adel0n commented Jul 16, 2023

Search first

  • I searched and no similar issues were found

What Happened?

When pressing back on Android app to hide context menu, it return to previous page instead of hiding context menu.

Reproduce the Bug

  1. Open the context menu by long tap on bullet
  2. Press back button
  3. The app going back instead of closing the menu

Expected Behavior

If I press back when context menu is present, the app hides the menu instead of going back.

Screenshots

video_2023-07-16_21-30-15.mp4

Desktop or Mobile Platform Information

Device: Xiaomi Mi 10 Pro
OS: Android 13 (api 33 build V14.0.3.0.TJAEUXM)
Logseq: 0.9.10

Additional Context

No response

Are you willing to submit a PR? If you know how to fix the bug.

  • I'm willing to submit a PR (Thank you!)
@andelf andelf self-assigned this Jul 17, 2023
@andelf andelf added :type/bug Something isn't working. Affects daily use. mobile:android labels Jul 17, 2023
@sprocketc
Copy link
Collaborator

sprocketc commented Jul 17, 2023

I think the issue can also be reproduced on desktop, if we use a keyboard shortcut to navigate back/forward.
Something like (set! js/window.onhashchange #(state/hide-custom-context-menu!)) might fix this.

@andelf
Copy link
Collaborator

andelf commented Jul 18, 2023

@sprocketc Confirmed this is reproducible on the desktop version too.
Thanks for the neat fix.

andelf added a commit that referenced this issue Jul 18, 2023
fix: dev warnings from react about missing keys

Fix #9872
andelf added a commit that referenced this issue Jul 19, 2023
fix: dev warnings from react about missing keys

Fix #9872
andelf added a commit that referenced this issue Jul 19, 2023
fix: dev warnings from react about missing keys

Fix #9872
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:type/bug Something isn't working. Affects daily use.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants