Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Right sidebar pane header wrap and content padding #10072

Merged
merged 4 commits into from Aug 22, 2023
Merged

Fix: Right sidebar pane header wrap and content padding #10072

merged 4 commits into from Aug 22, 2023

Conversation

sprocketc
Copy link
Collaborator

Resolves the following feedback from #10066

the title was originally a complete breadcrumb navigation, but it was omitted as a line, which made it impossible to see the context intuitively

the current new right sidebar makes the available windows smaller

Also resolves https://discord.com/channels/725182569297215569/735747000649252894/1143220597732687933

@sprocketc sprocketc marked this pull request as draft August 21, 2023 18:11
@sprocketc sprocketc changed the title Fix: Right sidebar pane header wrap and content padding [WIP] Fix: Right sidebar pane header wrap and content padding Aug 21, 2023
@sprocketc sprocketc marked this pull request as ready for review August 21, 2023 19:52
@sprocketc sprocketc changed the title [WIP] Fix: Right sidebar pane header wrap and content padding Fix: Right sidebar pane header wrap and content padding Aug 22, 2023
tiensonqin
tiensonqin approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@tiensonqin tiensonqin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Work great! 💯

@tiensonqin tiensonqin merged commit 6ce6b19 into master Aug 22, 2023
6 checks passed
@tiensonqin tiensonqin deleted the fix/right-sidebar-pane-header-and-content-padding branch August 22, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiensonqin tiensonqin tiensonqin approved these changes

Assignees
No one assigned
Labels
:type/bug-fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sprocketc @tiensonqin