Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/Improved Search and Color Switcher #10132

Merged
merged 170 commits into from Nov 14, 2023
Merged

Feat/Improved Search and Color Switcher #10132

merged 170 commits into from Nov 14, 2023

Conversation

bendyorke
Copy link
Contributor

@bendyorke bendyorke commented Sep 1, 2023 •
edited by logseqramses

This is a new implementation on Search, it allows searching for multiple groups including:

  1. pages
  2. commands
  3. blocks
  4. blocks on the current page
  5. files

It also enables:

  1. Search only pages/commands/etc
  2. Open Search in the sidebar

This PR also introduces Radix theme && colors and adds several Shui UI components including Button and Shortcut. We plan to integrate Shadcn into Logseq soon, so some components might be replaced with shadcn in the future.

CleanShot 2023-11-14 at 15 05 42@2x

Demos

New accent color switcher

Radix-themes.mp4

Open search result in sidebar

cmd-k-right-sidebar.mp4

Filter search results

cmd-k-filter.mp4

Expand search results

cmd-k-expand-results.mp4

@github-actions github-actions bot added the :type/feature New feature label Sep 1, 2023
@logseq-cldwalker logseq-cldwalker mentioned this pull request Oct 5, 2023
Open
2 tasks
xyhp915 and others added 18 commits November 13, 2023 21:55
@xyhp915
enhance(ui): shui button
6339842
@xyhp915
fix(ui): shui button internal theme state
0e1295b
@xyhp915
Merge branch 'feat/cmdk' of https://github.com/logseq/logseq into fea…
5681452 
…t/cmdk
@xyhp915
Revert "Merge branch 'feat/cmdk' of https://github.com/logseq/logseq …
b05a4df 
…into feat/cmdk"

This reverts commit 5681452, reversing
changes made to 0e1295b.
@tiensonqin
fix: lint warning
b1eacf9
@tiensonqin
chore: replace shui__ with ui__
2a62767 
Theme creators don't need to know about shui.
@tiensonqin
fix: lint warnings
88acf53
@tiensonqin
Merge branch 'master' into feat/cmdk
bbc6e5f
@xyhp915
enhance(ui): polish document text color
eee0410
@tiensonqin
fix: whiteboards e2e tests
bb1f0a2
@xyhp915
fix(ui): polish the active navigation items color
eaea4bd
@xyhp915
Merge branch 'feat/cmdk' of https://github.com/logseq/logseq into fea…
450f20a 
…t/cmdk
@tiensonqin
fix: editor e2e tests
8e0a700
@xyhp915
fix(ux): open in right sidebar with click
843e3d5
@xyhp915
Merge branch 'feat/cmdk' of https://github.com/logseq/logseq into fea…
5023316 
…t/cmdk
@tiensonqin
fix: whiteboard selected button bg
10a025e
@tiensonqin
add stage deployment for the master branch
a035be2
@tiensonqin
fix: update workflow
0e1d7da
@tiensonqin tiensonqin merged commit 4fd46a2 into master Nov 14, 2023
8 checks passed
@tiensonqin tiensonqin deleted the feat/cmdk branch November 14, 2023 07:28
logseq-cldwalker added a commit that referenced this pull request Nov 14, 2023
@logseq-cldwalker
fix: multiple choice not working due to #10132
80ac797 
looks like there's a breaking change with ui/button's options
@andelf andelf mentioned this pull request Nov 20, 2023
Merged
@logseqramses logseqramses changed the title Feat/cmdk Feat/Search Nov 28, 2023
@logseqramses logseqramses changed the title Feat/Search Feat/Improved Search and Color Switcher Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xyhp915 xyhp915 xyhp915 approved these changes

Assignees
No one assigned
Labels
:type/feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bendyorke @Bad3r @henices @xyhp915 @tiensonqin