Feat (Whiteboards): Pen mode (palm rejection) #10222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sprocketc
changed the title
sprocketc
changed the title
sprocketc
changed the title
sprocketc
changed the title
andelf
reviewed
Sep 20, 2023
There was a problem hiding this comment.
On Galaxy Tab S7+ with S Pen:
when "Pen mode" is on, even the tip of the pen is not touching the screen, a line will be drawn. It also connects directly to the tail of the last line.
S Pen has a special mode, when the tip is close to the screen (about 2cm), a transparent cursor will be shown on the screen.
|
@andelf Sorry for the late reply.
I don't have a samsung device to test this, but I tried to fix this blindly using this piece of information. I assume that this is a secondary pointer, so checking for isPrimary might fix this. Let me know if that improved the situation. |
andelf
approved these changes
Sep 28, 2023
andelf
force-pushed
the
feature/pen-mode
branch
from
c7692e0
to
aed0dc1
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simplified approach to pen mode. When this mode is enabled, non 'pen' type pointer events will be rejected.
Although this feature needs to be explicitly enabled, it would be nice if we could test this on multiple different devices before release. It seems to work fine on my wacom tablet on linux. I also made some minor style adjustments to our bottom toolbars for mobile.
Resolves #9863
Also see
https://discuss.logseq.com/t/whiteboards-could-really-do-with-palm-rejection-for-use-on-tablets/16769
https://discuss.logseq.com/t/whiteboard-ipad-apple-pencil-support/17526