Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance(electron): ctrl or cmd + = to zoom #10241

Merged
merged 1 commit into from
Sep 27, 2023
Merged

enhance(electron): ctrl or cmd + = to zoom #10241

merged 1 commit into from
Sep 27, 2023

Conversation

alan-roe
Copy link
Contributor

I've modified the source to enable zooming as per this issue: #5637

It is a longstanding issue from the electron project, found and implemented a workaround as per the docs.

To configure a local keyboard shortcut, you need to specify an accelerator property when creating a MenuItem within the Menu module.

@CLAassistant
Copy link

CLAassistant commented Sep 19, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

andelf
andelf approved these changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@andelf andelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
C-+(with shift pressed) and C-= both work.

@andelf andelf merged commit 7c0e5ed into logseq:master Sep 27, 2023
6 checks passed
@jn64 jn64 mentioned this pull request Mar 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andelf andelf andelf approved these changes

@xyhp915 xyhp915 Awaiting requested review from xyhp915

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alan-roe @CLAassistant @andelf