Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editor): drag and drop to dummy page #10292

Merged
merged 1 commit into from Sep 27, 2023
Merged

fix(editor): drag and drop to dummy page #10292

merged 1 commit into from Sep 27, 2023

Conversation

andelf
Copy link
Collaborator

@andelf andelf commented Sep 27, 2023 •
edited

See-also: #10104, #10262

  • Add drop handler to dummy-page component
  • Add the same style as dnd-separator(only top border, since incoming blocks always appear at the top of the page)

To Reproduce:

  • Use any calendar plugin, click and nav to a non-exsit page, then dummy-page will shown.
  • Drag a block from the right side bar to the "Click here to edit..." placeholder

xyhp915
xyhp915 approved these changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@xyhp915 xyhp915 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andelf andelf merged commit d67f473 into master Sep 27, 2023
7 checks passed
@andelf andelf deleted the fix/drop-to-dummy-page branch September 27, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xyhp915 xyhp915 xyhp915 approved these changes

@logseq-cldwalker logseq-cldwalker Awaiting requested review from logseq-cldwalker

Assignees
No one assigned
Labels
:type/bug-fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andelf @xyhp915