Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong date fn usage in #10350 #10422

Merged
merged 1 commit into from Oct 27, 2023
Merged

fix: wrong date fn usage in #10350 #10422

merged 1 commit into from Oct 27, 2023

Conversation

andelf
Copy link
Collaborator

@andelf andelf commented Oct 27, 2023

Wrong date fn usage introduced in #10350.

Error in dev mode:

Write file failed, please copy the changes to other editors in case of losing data.

Error: Error: Assert failed: (instance? goog.date.Date dt)
at Object.cljs_time$format$unparse [as unparse] (./js/cljs-runtime/cljs_time.format.js:686:8)
at Object.frontend$date$date__GT_file_name [as date__GT_file_name] (./js/cljs-runtime/frontend.date.js:235:25)
at Object.frontend$modules$file$core$transact_file_tx_if_not_exists_BANG_ [as transact_file_tx_if_not_exists_BANG_] (./js/cljs-runtime/frontend.modules.file.core.js:168:57)
at Object.frontend$modules$file$core$save_tree_BANG_ [as save_tree_BANG_] (./js/cljs-runtime/frontend.modules.file.core.js:245:35)
at Object.frontend$modules$outliner$file$do_write_file_BANG_ [as do_write_file_BANG_] (./js/cljs-runtime/frontend.modules.outliner.file.js:36:35)
at Object.frontend$modules$outliner$file$write_files_BANG_ [as write_files_BANG_] (./js/cljs-runtime/frontend.modules.outliner.file.js:97:36)
at eval (./js/cljs-runtime/frontend.modules.outliner.file.js:182:32)
at switch__27887__auto__ (./js/cljs-runtime/frontend.util.js:2224:122)
at eval (./js/cljs-runtime/frontend.util.js:2737:29)
at Function.frontend$util$state_machine__27888__auto____1 [as cljs$core$IFn$_invoke$arity$1] (./js/cljs-runtime/frontend.util.js:2759:4)

@andelf andelf merged commit 99a38de into master Oct 27, 2023
7 checks passed
@andelf andelf deleted the fix/date-misuse branch October 27, 2023 11:57
@Bad3r
Copy link
Collaborator

Bad3r commented Oct 29, 2023

@andelf there seems to be an issue now when linking/creating pages with a date as a title.

for example add the following blocks to a page:

- [[2022-10-10]]
- [[2023-10-28]]
- [[2023_10_28]]

when clicking on any of these pages the result is an empty page
Recording - 29 Oct 2023.webm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants