Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pdf): add zoom via touchpad #10435

Merged
merged 7 commits into from Oct 31, 2023
Merged

feat(pdf): add zoom via touchpad #10435

merged 7 commits into from Oct 31, 2023

Conversation

CorrectRoadH
Copy link
Contributor

@CorrectRoadH CorrectRoadH commented Oct 30, 2023 •
edited

close #8376

What does the PR do?

add listener to wheel event to trigger zoom out or zoom in.

Screenshot

CleanShot 2023-10-30 at 18 57 28

@CorrectRoadH CorrectRoadH marked this pull request as draft October 30, 2023 10:05
@CLAassistant
Copy link

CLAassistant commented Oct 30, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@CorrectRoadH CorrectRoadH marked this pull request as ready for review October 30, 2023 10:58
@CorrectRoadH CorrectRoadH changed the title [WIP]feat(pdf): add zoom via touchpad feat(pdf): add zoom via touchpad Oct 30, 2023
@CorrectRoadH
Copy link
Contributor Author

@xyhp915 Please take a look

@xyhp915 xyhp915 self-requested a review October 30, 2023 12:17
@xyhp915 xyhp915 self-assigned this Oct 30, 2023
@andelf andelf self-requested a review October 30, 2023 13:26
andelf
andelf approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@andelf andelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But the overall operation is rather laggy

@CorrectRoadH
Copy link
Contributor Author

LGTM. But the overall operation is rather laggy

OK. I have reduced the debounce time. It work more smoothly.

IMG_2068.MOV

@andelf andelf merged commit 89cd619 into logseq:master Oct 31, 2023
6 checks passed
xyhp915 added a commit that referenced this pull request Nov 1, 2023
@xyhp915
Revert "feat(pdf): add zoom via touchpad (#10435)"
b2a10fc 
This reverts commit 89cd619.
@xyhp915 xyhp915 mentioned this pull request Nov 1, 2023
Merged
andelf pushed a commit that referenced this pull request Nov 1, 2023
@xyhp915 @andelf
Revert "feat(pdf): add zoom via touchpad (#10435)"
43c8e1c 
This reverts commit 89cd619.
@kmr0209
Copy link

kmr0209 commented Nov 17, 2023

Is this only possible in Mac Os? Im on window and cant use it at all.

@CorrectRoadH
Copy link
Contributor Author

Is this only possible in Mac Os? Im on window and cant use it at all.

🤣The feature has been reverted. Because there is a bug when using the mouse

@TTTPOB TTTPOB mentioned this pull request Feb 19, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andelf andelf andelf approved these changes

@xyhp915 xyhp915 xyhp915 approved these changes

Assignees

@xyhp915 xyhp915

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PDF Zoom doesn't work using touchpad pinch-to-zoom on laptop
5 participants
@CorrectRoadH @CLAassistant @kmr0209 @andelf @xyhp915