Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new search issues #10584

Merged
merged 7 commits into from Nov 30, 2023
Merged

Conversation

@tiensonqin tiensonqin changed the title fix: remove built-in properties from search results Fix new search issues Nov 30, 2023
Copy link
Collaborator

@logseq-cldwalker logseq-cldwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiensonqin Tested all the fixes and they work great! 🐛 ⚡ I'm not sure if removing deleted pages from Recents is improved ux. It may confuse users if they rely on Recents as unmodified history

@tiensonqin
Copy link
Contributor Author

@logseq-cldwalker Maybe we can leave the deleted pages in Recents and show a message like "This page has been deleted, do you want to create a new one or remove it from Recents?". I'm going to merge this PR, we can improve this later with more feedback.

@tiensonqin tiensonqin force-pushed the fix/remove-built-in-properties-from-search branch from 803db73 to ad0196a Compare November 30, 2023 14:27
@tiensonqin tiensonqin merged commit 7ec93f0 into master Nov 30, 2023
6 of 7 checks passed
@tiensonqin tiensonqin deleted the fix/remove-built-in-properties-from-search branch November 30, 2023 14:31
@stdword
Copy link
Contributor

stdword commented Nov 30, 2023

@logseq-cldwalker Maybe we can leave the deleted pages in Recents and show a message like "This page has been deleted, do you want to create a new one or remove it from Recents?". I'm going to merge this PR, we can improve this later with more feedback.

The nice idea of Recents was like it were before New Search: Recents is a search terms. And selecting the search term leads to input it to query filed, not to opening a page.
This idea has advantages:

  1. There is no problem with deleted pages
  2. It solves the case when I make a mistake in prev search and want to change only one character, not the whole page name (which can be very long)
  3. This partially solves the requests like this one, without a special shortcut (but TAB-like shortcut (or right arrow) still a very nice idea for very long page names with complex hierarchy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants