-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore (Whiteboards): Cleanup, LSUI components and minor fixes #10906
Conversation
@sprocketc This looks great. Before QAing, could some of this PR like the tldraw and component work be a PR against master first? Asking because I'm hoping to reduce conflicts from master into feat/db which happen fairly regularly and we don't have a date yet for merging db back to master. If you don't plan on working or fixing on whiteboards off master much then this question probably isn't as relevant |
@logseq-cldwalker Hey! This was based on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sprocketc Looks good! 👍 🚢 I didn't QA the new fixes but I did QA that whiteboard creation and editing work in file graphs and db graphs. I also confirmed published whiteboards still work. Thanks for all the cleanup, especially moving tldraw 😄
One whiteboard regression which probably isn't related to this PR is that we no longer show a whiteboard icon next to a whiteboard page ref e.g. |
]
a5eadd8ui.js
from repo and update LSUI build process 8fd90fa