Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore (Whiteboards): Cleanup, LSUI components and minor fixes #10906

Merged
merged 52 commits into from
Feb 1, 2024

Conversation

sprocketc
Copy link
Collaborator

@sprocketc sprocketc commented Jan 23, 2024

  • Move tldraw to packages
  • Remove unneeded assets b17a3d0
  • Fix visual inconsistencies of shortcuts on context menu 071709d
  • Fix background color on image export (one of the new theme colors needs to be selected to reproduce) 1866655
  • Fix input height on WB title edit 2681632
  • Fix bringForward shortcut ] a5eadd8
  • Remove ui.js from repo and update LSUI build process 8fd90fa
  • Replace radix components with LSUI variants (there is an overlap with Enhance(ui): refactoring dropdown/context menu with the new components #10897, so I skipped the context menu). The main goal was to avoid using radix components directly. We can replace more custom components later (buttons, icons etc)
    • tooltip
    • popover
    • select (arrow icon on LSUI is now optional)
    • dropdown-menu e715b35
    • switch (unused so I removed the tldraw component) e322476
    • separator (added to LSUI) 62569a7
    • toggle & toggle-group (added to LSUI) 4dd444e
    • slider (exported sub-components in LSUI to support custom children) 2206068

@github-actions github-actions bot added the :type/dev This label is used to indicate that an issue or PR is related to development tasks or changes that label Jan 23, 2024
@sprocketc sprocketc changed the title [WIP] Chore(whiteboards): Cleanup and fixes [WIP] Chore (Whiteboards): Cleanup and fixes Jan 23, 2024
@sprocketc sprocketc changed the title [WIP] Chore (Whiteboards): Cleanup and fixes Chore (Whiteboards): Cleanup, LSUI components and fixes Jan 30, 2024
@sprocketc sprocketc changed the title Chore (Whiteboards): Cleanup, LSUI components and fixes Chore (Whiteboards): Cleanup, LSUI components and minor fixes Jan 30, 2024
@sprocketc sprocketc marked this pull request as ready for review January 30, 2024 15:15
@logseq-cldwalker
Copy link
Collaborator

@sprocketc This looks great. Before QAing, could some of this PR like the tldraw and component work be a PR against master first? Asking because I'm hoping to reduce conflicts from master into feat/db which happen fairly regularly and we don't have a date yet for merging db back to master. If you don't plan on working or fixing on whiteboards off master much then this question probably isn't as relevant

@sprocketc
Copy link
Collaborator Author

sprocketc commented Jan 31, 2024

@logseq-cldwalker Hey! This was based on feat/db in consultation with @tiensonqin. I believe the reason is to be in sync with the main development efforts and to also identify and fix db related issues. I agree with you that this will be fine, as long as we stick to the plan. I have no problem switching to master if we agree to it.

Copy link
Collaborator

@logseq-cldwalker logseq-cldwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sprocketc Looks good! 👍 🚢 I didn't QA the new fixes but I did QA that whiteboard creation and editing work in file graphs and db graphs. I also confirmed published whiteboards still work. Thanks for all the cleanup, especially moving tldraw 😄

@logseq-cldwalker
Copy link
Collaborator

One whiteboard regression which probably isn't related to this PR is that we no longer show a whiteboard icon next to a whiteboard page ref e.g. [[whiteboard page]]

@logseq-cldwalker logseq-cldwalker merged commit 5050125 into feat/db Feb 1, 2024
2 checks passed
@logseq-cldwalker logseq-cldwalker deleted the chore/whiteboards-cleanup branch February 1, 2024 13:43
@sprocketc sprocketc mentioned this pull request Feb 27, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:type/dev This label is used to indicate that an issue or PR is related to development tasks or changes that
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants