Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mobile): incorrect theme color for the android status bar #11272

Merged
merged 1 commit into from May 13, 2024

Conversation

xyhp915
Copy link
Collaborator

@xyhp915 xyhp915 commented Apr 27, 2024

After

screen-20240427-154559.mp4

(let [rgb (-> bg-color
(string/replace #"^rgb\(" "")
(string/replace #"^rgb[^\d]+" "")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the left bracket ignored?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The left bracket is included.
CleanShot 2024-04-29 at 16 57 58@2x

@xyhp915 xyhp915 requested a review from andelf April 29, 2024 09:03
@chronos1970
Copy link

Closes #11065

@xyhp915 xyhp915 requested a review from tiensonqin May 6, 2024 04:16
Copy link
Collaborator

@andelf andelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andelf andelf merged commit 7ba72ae into master May 13, 2024
6 checks passed
@andelf andelf deleted the fix/android-status-bar branch May 13, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants