fix empty block children is not clickable issue #3593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've been using a temporary fix in my custom.css .block-children {
width: 100%;
}
The same as w-full. |
andelf
approved these changes
Dec 27, 2021
|
Do we need a e2e case for it? |
|
I prefer not to test the geometric properties of an element. This is a buggy modification introduced by accident. CSS modifications should be carefully reviewed. |
tiensonqin
approved these changes
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3559, block children are wrapped into a
flexcontainer, but it previously took all available width, after the change it only takes its children width. This issue will make the width of block children smaller. For empty block children, they are not clickable.