Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add {{namespace [[page]]}} macro which can be used as a toc #3616

Merged
merged 5 commits into from Dec 28, 2021

Conversation

tiensonqin
Copy link
Contributor

@tiensonqin tiensonqin commented Dec 27, 2021

{{namespace [[Book 1]]}} can be rendered as:
CleanShot 2021-12-28 at 15 10 46

@tiensonqin tiensonqin marked this pull request as ready for review December 28, 2021 07:13

(when (seq images)
(lightbox/preview-images! images))))}
images (to-array images)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the editor setting changed? There shouldn't be so many whitespace changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what happened in my editor :)
CleanShot 2021-12-28 at 15 42 49
Shall we force the code style through some code formatters in CI?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fancify-symbols enabled?
the alignment is offset by 1, fn <-> \lambda

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, prettify-symbols-mode was enabled.

Copy link
Collaborator

@andelf andelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiensonqin tiensonqin merged commit eb20a95 into master Dec 28, 2021
@tiensonqin tiensonqin deleted the feat/namespace-macro branch December 28, 2021 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Namespace References are not always rendering
3 participants