Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin): allow target attribution in provideUI #3661

Merged
merged 1 commit into from Dec 29, 2021

Conversation

YangKeao
Copy link
Contributor

Without target="_blank" attribution, the plugin cannot render an external link (or this link will always be opened in current window).

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@xyhp915 xyhp915 self-requested a review December 29, 2021 12:31
Copy link
Collaborator

@xyhp915 xyhp915 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tiensonqin
Copy link
Contributor

@YangKeao Thank you for the help!

@tiensonqin tiensonqin merged commit e56bf09 into logseq:master Dec 29, 2021
@YangKeao YangKeao mentioned this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants