Removing nil orphans #3809
Merged
Removing nil orphans #3809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andelf
approved these changes
Jan 7, 2022
|
Thanks for the fix! logseq/src/main/frontend/db/model.cljs Line 1506 in e438069 Just a guess, and #3797 is addressing such cases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3774. When printing the returned list of orphaned pages, turns out a lot of them are nil.
Simply removing these seems to fix the problem on my side. However, I'm not exactly sure why these are nil, whether there is a deeper underlying problem (we're already filtering for false).