Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(electron): open external file with default app #3863 #3867

Merged
merged 1 commit into from Jan 11, 2022

Conversation

xyhp915
Copy link
Collaborator

@xyhp915 xyhp915 commented Jan 11, 2022

resolved #3863

Copy link
Collaborator

@andelf andelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andelf andelf requested review from cnrpman and llcc January 11, 2022 13:56
Copy link
Collaborator

@cnrpman cnrpman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andelf andelf merged commit 47123ad into master Jan 11, 2022
@andelf andelf deleted the fix/open-external-file-with-default-app branch January 11, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Javascript error when trying to link local video
3 participants