Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add Windows develop instruction #4263

Merged
merged 4 commits into from Feb 22, 2022

Conversation

cnrpman
Copy link
Collaborator

@cnrpman cnrpman commented Feb 18, 2022

No description provided.

@cnrpman cnrpman added the :type/dev This label is used to indicate that an issue or PR is related to development tasks or changes that label Feb 18, 2022
@tiensonqin
Copy link
Contributor

@cnrpman Logseq instead of LogSeq :)

@cnrpman cnrpman force-pushed the doc-windows-develop-instruction branch from 6848bed to 4619c7c Compare February 18, 2022 14:05
Copy link
Collaborator

@logseq-cldwalker logseq-cldwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cnrpman Thanks for adding windows instructions! 👍 ✏️ Gave some minor suggestions that you're welcome to use or not

docs/Develop LogSeq on Windows.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/Develop LogSeq on Windows.md Outdated Show resolved Hide resolved
docs/Develop LogSeq on Windows.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
* `cd ..`

Then do the `gulp`'s job manually (as it's not available on Windows). Folloing commands are equivalent to `yarn dev-electron-app`:
* copy files in `resources` to `static`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does npx gulp build work here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth a try

@cnrpman cnrpman force-pushed the doc-windows-develop-instruction branch from e5f1158 to 1577a95 Compare February 19, 2022 04:05
Co-authored-by: Gabriel Horner <97210743+logseq-cldwalker@users.noreply.github.com>
@cnrpman cnrpman force-pushed the doc-windows-develop-instruction branch from 1577a95 to b5fa33a Compare February 19, 2022 04:14
docs/develop-logseq-on-windows.md Show resolved Hide resolved
docs/develop-logseq-on-windows.md Outdated Show resolved Hide resolved
docs/develop-logseq-on-windows.md Outdated Show resolved Hide resolved
@cnrpman cnrpman force-pushed the doc-windows-develop-instruction branch from bc5517f to d0be408 Compare February 19, 2022 17:22
README.md Outdated Show resolved Hide resolved
Co-authored-by: Gabriel Horner <97210743+logseq-cldwalker@users.noreply.github.com>
@tiensonqin tiensonqin merged commit 8c64e7c into logseq:master Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:type/dev This label is used to indicate that an issue or PR is related to development tasks or changes that
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants