fix: wrong logbook creation #4382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andelf
reviewed
Feb 25, 2022
logseq-cldwalker
approved these changes
Feb 25, 2022
There was a problem hiding this comment.
@llcc Confirmed this fixes the first two bugs/enhancements! 👍 🚢 There's some minor feedback in marker.cljs to think about
cnrpman
requested changes
Mar 1, 2022
… into fix-wrong-logbook-creation
|
@llcc It seems that bumping mldoc made the CI tests fail, I've updated yarn.lock in the master branch. Rebase on master should fix it. |
cnrpman
requested changes
Mar 2, 2022
llcc
force-pushed
the
fix-wrong-logbook-creation
branch
from
4e4b3c7
to
f90fca1
Compare
logseq-cldwalker
added a commit
that referenced
this pull request
Mar 2, 2022
No need to have set-marker impl copied with with-redefs. Move tests to its corresponding test ns
logseq-cldwalker
added a commit
that referenced
this pull request
Mar 3, 2022
…ook-creation Dev: Rewrite tests from #4382 to use with-redefs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOING/NOWmarker exists in center of block. close LOGBOOK is generated in WARNING Admonition #3746, only show the first property, caused by the logbook drawer produced by a block have the "DOING" string #4381