enhance: backup files when there're differences between db and disk #4421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, files are backuped to logseq/bak when logseq detects there're differences between the db and disk. But it has two problems: 1. Only a few of users know `logseq/bak`, other users think that their data has been lost. 2. Files in the logseq/bak folder are never truncated. This PR backups old file in DB with timestamp suffixes instead of logesq/bak, and only keep the latest 10 versions of any changed file.
github-actions
bot
added
the
:type/enhancement
andelf
reviewed
Mar 2, 2022
| (let [dir (path/dirname file-path) | ||
| files (fs/readdirSync dir (clj->js {:withFileTypes true})) | ||
| files (map #(.-name %) files) | ||
| prefix (str (path/basename file-path) ".") |
There was a problem hiding this comment.
A special case for this prefix check:
what if a user creates a page "A" and then "A/md".
There was a problem hiding this comment.
basename will return the file name with the suffix, e.g. a.md, prefix here has an ending . so that a.md will not be deleted if we want to truncate the history files for the page A.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, files are stored to logseq/bak when logseq detects
there're differences between the db and disk. But it has two problems:
logseq/bak, other users think that theirdata has been lost.
This PR backups old files in DB with timestamp suffixes instead of
logesq/bak, and only keep the latest 10 versions of any changed file.