Fix some UI warnings #4436
Merged
Fix some UI warnings #4436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andelf
commented
Mar 3, 2022
| @@ -45,7 +45,7 @@ | |||
| ^js parent (.closest target ".nav-content-item")] | |||
| (.toggle (.-classList parent) "is-expand")))} | |||
|
|
|||
| [:a.font-medium.fade-link name] | |||
| [:div.font-medium.fade-link name] | |||
There was a problem hiding this comment.
name is used with [:a ....]
logseq-cldwalker
approved these changes
Mar 3, 2022
| (->> m | ||
| (filter (comp some? val)) |
There was a problem hiding this comment.
Would be great if we removed conditionals from commands altogether. They also caused issues when writing up the bb lang tasks. I'll see if I can address that soon
logseq-cldwalker
added a commit
that referenced
this pull request
Mar 28, 2022
Also fixed inactive commands showing up in settings page. This is a follow up to #4436
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some UI warnings
Warning: validateDOMNesting(...): <a> cannot appear as a descendant of <a>.