Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ✨ notifications-content support \n #4451

Merged
merged 2 commits into from Mar 5, 2022
Merged

feat: ✨ notifications-content support \n #4451

merged 2 commits into from Mar 5, 2022

Conversation

haydenull
Copy link
Contributor

logseq.App.showMsgnotifications-content support \n

before:
image

after:
image

@cnrpman
Copy link
Collaborator

cnrpman commented Mar 4, 2022 •
edited

Good catch! Better to add it to the css?

logseq/src/main/frontend/ui.css

Lines 61 to 64 in 24b0236

.notification-area {
background-color: var(--ls-tertiary-background-color, #fff);
color: var(--ls-primary-text-color);
}

image

@cnrpman cnrpman added the :type/enhancement Enhancement to product. Does not affect the overall basic use. label Mar 4, 2022
@cnrpman cnrpman self-requested a review March 4, 2022 12:14
andelf
andelf reviewed Mar 4, 2022
View reviewed changes
src/main/frontend/ui.cljs Outdated Show resolved Hide resolved
cnrpman
cnrpman approved these changes Mar 5, 2022
View reviewed changes
Copy link
Collaborator

@cnrpman cnrpman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

andelf
andelf approved these changes Mar 5, 2022
View reviewed changes
Copy link
Collaborator

@andelf andelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andelf andelf merged commit 1420e83 into logseq:master Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andelf andelf andelf approved these changes

@cnrpman cnrpman cnrpman approved these changes

Assignees
No one assigned
Labels
:type/enhancement Enhancement to product. Does not affect the overall basic use.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@haydenull @cnrpman @andelf