Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/open file backups directory #4526

Merged
merged 3 commits into from Mar 10, 2022
Merged

Feat/open file backups directory #4526

merged 3 commits into from Mar 10, 2022

Conversation

tiensonqin
Copy link
Contributor

This PR enables users to open a specific page's corresponding backups directory located in logseq/bak/...related-page-dir.
https://www.loom.com/share/33c3fb431cd844aa82687f1819a34361

@github-actions github-actions bot added the :type/feature New feature label Mar 10, 2022
cnrpman
cnrpman approved these changes Mar 10, 2022
View reviewed changes
Copy link
Collaborator

@cnrpman cnrpman left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

An optional suggestion:
No action for clicking the button when there's no such a bak directory. Should we have a prompting, or just turn the button to gray color?
Also applied to the "check page history" button when there's no git setup.

@tiensonqin tiensonqin merged commit f134255 into master Mar 10, 2022
@tiensonqin tiensonqin deleted the feat/open-file-backups-directory branch March 10, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnrpman cnrpman cnrpman approved these changes

@andelf andelf Awaiting requested review from andelf

@xyhp915 xyhp915 Awaiting requested review from xyhp915

@llcc llcc Awaiting requested review from llcc

@RCmerci RCmerci Awaiting requested review from RCmerci

Assignees
No one assigned
Labels
:type/feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tiensonqin @cnrpman