Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #+keyword issues in orgmode #4573

Merged
merged 7 commits into from Mar 16, 2022
Merged

fix #+keyword issues in orgmode #4573

merged 7 commits into from Mar 16, 2022

Conversation

llcc
Copy link
Contributor

@llcc llcc commented Mar 14, 2022 •
edited

Demo: https://www.loom.com/share/d08f355e2a964ffe87c40f1aea26a325

@github-actions github-actions bot added the :type/enhancement Enhancement to product. Does not affect the overall basic use. label Mar 14, 2022
@llcc llcc requested review from tiensonqin, andelf, RCmerci and logseq-cldwalker and removed request for tiensonqin and andelf March 14, 2022 14:14
@llcc
fix(orgmode): don't parse some in-file #+keyword as page properties
b60f75c 
e.g. #+Name:, #+tblfm:, etc.
@llcc
enhance(orgmode): display image and table's caption keyword
d160d3a 
https://orgmode.org/manual/Captions.html
@llcc
enhance(orgmode): ignore some #+keywords for parsing properties.
62b1e8b 
Orgmode uses lots of file level #+keyword: styled keywords[1].
Logseq parses their value as page references except `title` and
`filters`, which pollutes Logseq database.

Users can setup `:ignored-page-property-tags` in config.edn to
make Logseq not parsing those keywords.

[1]: https://orgmode.org/manual/In_002dbuffer-Settings.html.
@llcc llcc force-pushed the enhance/in-buffer-settings-in-orgmode branch from 625dfd0 to 62b1e8b Compare March 15, 2022 00:50
@tiensonqin
Copy link
Contributor

@llcc There're some conflicts that are introduced by merging other PRs.

tiensonqin
tiensonqin approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@tiensonqin tiensonqin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/main/frontend/format/mldoc.cljs Outdated Show resolved Hide resolved
templates/config.edn Outdated Show resolved Hide resolved
@llcc llcc force-pushed the enhance/in-buffer-settings-in-orgmode branch from 5e789a5 to a1e845b Compare March 16, 2022 08:45
@tiensonqin tiensonqin merged commit 1361728 into master Mar 16, 2022
@tiensonqin tiensonqin deleted the enhance/in-buffer-settings-in-orgmode branch March 16, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiensonqin tiensonqin tiensonqin approved these changes

@RCmerci RCmerci Awaiting requested review from RCmerci

@andelf andelf Awaiting requested review from andelf

@logseq-cldwalker logseq-cldwalker Awaiting requested review from logseq-cldwalker

Assignees
No one assigned
Labels
:type/enhancement Enhancement to product. Does not affect the overall basic use.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@llcc @tiensonqin