Fix blank screen on home page #4575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also used this on malformed advanced queries to improve styling and communication of error
| @@ -147,11 +147,15 @@ | |||
| (when (seq queries) | |||
| [:div#today-queries.mt-10 | |||
| (for [query queries] | |||
| (rum/with-key | |||
| (block/custom-query {:attr {:class "mt-10"} | |||
There was a problem hiding this comment.
Weirdly enough, this component has a catch-error but it was not taking effect
There was a problem hiding this comment.
It seems that rum components don't catch errors in both :init and :will-component lifecycles.
https://github.com/tonsky/rum/blob/gh-pages/src/rum/core.clj#L131-L138
There was a problem hiding this comment.
It's likely that lifecycle hooks have something to do with it but wouldn't explain why the page component works while custom-query doesn't
logseq-cldwalker
requested review from
tiensonqin,
xyhp915,
andelf,
cnrpman and
llcc
and removed request for
tiensonqin
tiensonqin
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #4539 where two users had shared default-queries that were causing their home screen to crash. This PR also improves the error handling of default-queries so that any future errors render an inline error instead of blanking the screen like:
This PR also introduces a reusable block-error component and uses it when advanced queries fail to parse correctly. Before it looked like:
and now the error looks like:
If we like this block-error component, I could use it in a couple more places where we render blocks errors with
div.warning ...