fix(ui): warn about illegal git commit interval #4924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llcc
reviewed
Apr 15, 2022
| (let [value (-> (util/evalue event) | ||
| util/safe-parse-int)] | ||
| (if (and (number? value) | ||
| (< 0 value (inc 600))) |
There was a problem hiding this comment.
I am also curious why we set the maximum interval?
There was a problem hiding this comment.
CC @tiensonqin
I personally prefer another approach: when max diff-lines is over xxx lines
There was a problem hiding this comment.
I'd also appreciate a different approach or a (way higher) maximum.
For people using Logseq throughout the day for small notes, a 10-min-commit is literally flooding someones git-activity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3162
Fix #2778